refactor: undo feature cover every single part of editor

src/uhm/components/Map.tsx

@@ -33,12 +33,15 @@ export type MapHandle = {
 
 type MapProps = {
     mode: EditorMode;
-    draft: FeatureCollection;
+    // FeatureCollection that should actually be rendered/interacted with on the map.
+    // Callers should apply timeline/replay filters before passing it here.
+    renderDraft: FeatureCollection;
     backgroundVisibility: BackgroundLayerVisibility;
     geometryVisibility?: Record<string, boolean>;
     selectedFeatureIds: (string | number)[];
     onSelectFeatureIds: (ids: (string | number)[]) => void;
     onSetMode?: (mode: EditorMode, featureId?: string | number) => void;
+    // Label lookup context only. It may include non-rendered geometries for entity label resolution.
     labelContextDraft?: FeatureCollection;
     labelTimelineYear?: number | null;
     onCreateFeature?: (feature: FeatureCollection["features"][number]) => void;
@@ -46,7 +49,7 @@ type MapProps = {
     onHideFeature?: (id: string | number) => void;
     onUpdateFeature?: (id: string | number, geometry: Geometry) => void;
     allowGeometryEditing?: boolean;
-    respectBindingFilter?: boolean;
+    applyGeometryBindingFilter?: boolean;
     height?: CSSProperties["height"];
     fitToDraftBounds?: boolean;
     fitBoundsKey?: string | number | null;
@@ -63,7 +66,7 @@ type MapProps = {
 const Map = forwardRef<MapHandle, MapProps>(function Map({
     mode,
     onSetMode,
-    draft,
+    renderDraft,
     backgroundVisibility,
     geometryVisibility,
     selectedFeatureIds,
@@ -75,7 +78,7 @@ const Map = forwardRef<MapHandle, MapProps>(function Map({
     onHideFeature,
     onUpdateFeature,
     allowGeometryEditing = true,
-    respectBindingFilter = true,
+    applyGeometryBindingFilter = true,
     height = "100vh",
     fitToDraftBounds = false,
     fitBoundsKey = null,
@@ -90,8 +93,8 @@ const Map = forwardRef<MapHandle, MapProps>(function Map({
 }, ref) {
     // Ref giữ mode mới nhất cho MapLibre handlers được register một lần.
     const modeRef = useRef<MapProps["mode"]>(mode);
-    // Ref giữ draft mới nhất để engine đọc không bị stale closure.
-    const draftRef = useRef<FeatureCollection>(draft);
+    // Ref giữ render draft mới nhất để map engines đọc không bị stale closure.
+    const renderDraftRef = useRef<FeatureCollection>(renderDraft);
     // Ref callback select feature mới nhất cho event click trên map.
     const onSelectFeatureIdsRef = useRef(onSelectFeatureIds);
     // Ref callback đổi mode mới nhất, dùng khi map interaction chuyển sang replay/select.
@@ -114,7 +117,7 @@ const Map = forwardRef<MapHandle, MapProps>(function Map({
     const onBindGeometriesRef = useRef<MapProps["onBindGeometries"]>(onBindGeometries);
  
     useEffect(() => { modeRef.current = mode; }, [mode]);
-    useEffect(() => { draftRef.current = draft; }, [draft]);
+    useEffect(() => { renderDraftRef.current = renderDraft; }, [renderDraft]);
     useEffect(() => { onSelectFeatureIdsRef.current = onSelectFeatureIds; }, [onSelectFeatureIds]);
     useEffect(() => { onSetModeRef.current = onSetMode; }, [onSetMode]);
     useEffect(() => { onHoverFeatureChangeRef.current = onHoverFeatureChange; }, [onHoverFeatureChange]);
@@ -159,7 +162,7 @@ const Map = forwardRef<MapHandle, MapProps>(function Map({
         mapRef,
         mode,
         modeRef,
-        draftRef,
+        renderDraftRef,
         allowGeometryEditing,
         selectedFeatureIds,
         onSelectFeatureIdsRef,
@@ -174,19 +177,19 @@ const Map = forwardRef<MapHandle, MapProps>(function Map({
 
     // Hook đồng bộ draft/layer/filter/highlight từ React state xuống MapLibre source/layer.
     const {
-        applyDraftToMap,
+        applyRenderDraftToMap,
         applyHighlightToMap,
         applyImageOverlayToMap,
         tryCenterToUserLocation,
     } = useMapSync({
         mapRef,
-        draft,
+        renderDraft,
         labelContextDraft,
         labelTimelineYear,
         backgroundVisibility,
         geometryVisibility,
         selectedFeatureIds,
-        respectBindingFilter,
+        applyGeometryBindingFilter,
         fitToDraftBounds,
         fitBoundsKey,
         highlightFeatures,
@@ -206,7 +209,7 @@ const Map = forwardRef<MapHandle, MapProps>(function Map({
         setupMapLayers(map, backgroundVisibility, highlightFeatures, applyHighlightToMap);
         applyImageOverlayToMap();
         setupMapInteractions(map);
-        applyDraftToMap(draftRef.current);
+        applyRenderDraftToMap(renderDraftRef.current);
         tryCenterToUserLocation();
 
         return () => {